chore(docs) make import node test recommended (#318)

* docs(documentation): make not import test recomended * chore: update node import test * chore(cleanup): update exports
veritem · Dec 11, 2023 · c2be10a · c2be10a
1 parent fc18ad2
commit c2be10a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -138,7 +138,7 @@ export default [
 | [no-focused-tests](docs/rules/no-focused-tests.md)                                                                       | Disallow focused tests                                                   |    | 🌐 | 🔧 |    |
 | [no-hooks](docs/rules/no-hooks.md)                                                                                       | Disallow setup and teardown hooks                                        |    | 🌐 |    |    |
 | [no-identical-title](docs/rules/no-identical-title.md)                                                                   | Disallow identical titles                                                | ✅  |    | 🔧 |    |
-| [no-import-node-test](docs/rules/no-import-node-test.md)                                                                 | Disallow importing `node:test`                                           |    | 🌐 | 🔧 |    |
+| [no-import-node-test](docs/rules/no-import-node-test.md)                                                                 | Disallow importing `node:test`                                           | ✅  | 🌐 | 🔧 |    |
 | [no-interpolation-in-snapshots](docs/rules/no-interpolation-in-snapshots.md)                                             | Disallow string interpolation in snapshots                               |    | 🌐 | 🔧 |    |
 | [no-large-snapshots](docs/rules/no-large-snapshots.md)                                                                   | Disallow large snapshots                                                 |    | 🌐 |    |    |
 | [no-mocks-import](docs/rules/no-mocks-import.md)                                                                         | Disallow importing from __mocks__ directory                              |    | 🌐 |    |    |

diff --git a/docs/rules/no-import-node-test.md b/docs/rules/no-import-node-test.md
@@ -1,6 +1,6 @@
 # Disallow importing `node:test` (`vitest/no-import-node-test`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
 

diff --git a/src/index.ts b/src/index.ts
@@ -84,7 +84,6 @@ const allRules = {
 	[noStandaloneExpectName]: 'warn',
 	[noTestPrefixesName]: 'warn',
 	[noTestReturnStatementName]: 'warn',
-	[noImportNodeTestName]: 'warn',
 	[preferCalledWithName]: 'warn',
 	[preferToBeFalsyName]: 'warn',
 	[preferToBeObjectName]: 'warn',
@@ -101,7 +100,6 @@ const allRules = {
 	[requireTopLevelDescribeName]: 'warn',
 	[requireToThrowMessageName]: 'warn',
 	[requireHookName]: 'warn',
-	[requireLocalTestContextForConcurrentSnapshotsName]: 'warn',
 	[preferTodoName]: 'warn',
 	[preferSpyOnName]: 'warn',
 	[preferComparisonMatcherName]: 'warn',
@@ -117,7 +115,8 @@ const recommended = {
 	[validTitleName]: 'error',
 	[validExpectName]: 'error',
 	[validDescribeCallbackName]: 'error',
-	[requireLocalTestContextForConcurrentSnapshotsName]: 'error'
+	[requireLocalTestContextForConcurrentSnapshotsName]: 'error',
+	[noImportNodeTestName]: 'error'
 }
 
 export default {

diff --git a/src/rules/no-import-node-test.ts b/src/rules/no-import-node-test.ts
@@ -9,7 +9,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
 	meta: {
 		docs: {
 			description: 'Disallow importing `node:test`',
-			recommended: 'warn'
+			recommended: 'strict'
 		},
 		type: 'suggestion',
 		messages: {