Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix smoke tests #474

Merged
merged 3 commits into from
Jun 12, 2024
Merged

test: fix smoke tests #474

merged 3 commits into from
Jun 12, 2024

Conversation

AriPerkkio
Copy link
Contributor

@AriPerkkio AriPerkkio commented Jun 12, 2024

Continues work from #470, with fix applied from #473.

Example run: https://github.com/AriPerkkio/eslint-plugin-vitest/actions/runs/9482770552/job/26128361215

  • chore: set packageManager

    • Lockfile seems to be generated with pnpm@9, but CIs are using pnpm@8
    • Contributors may end up re-generating whole lockfile if the version doesn't match with expected major
  • test: fix smoke tests

    • Run tests against 10K repositories from eslint-remote-tester-repositories, instead of just a single one
    • Use required peer dependency eslint@9 - the Node API of eslint@8 is not compatible with required version 9. I wonder why there's no warning from peerDependencies conflict 馃

Copy link
Owner

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@veritem veritem merged commit c8e9e9c into veritem:main Jun 12, 2024
@AriPerkkio AriPerkkio deleted the test/smoke-fix branch June 12, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants