VTN-29032, create interface to graphql client #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctsiokos-veritone
requested review from
robbiekb,
iocheredko-v,
mthiyagarajanveritone,
jay-a-brown,
franarama,
tnguyen-veri,
weilanveritone and
quynhdang-vt
weilanveritone
approved these changes
Aug 29, 2019
jay-a-brown
approved these changes
Aug 29, 2019
ctsiokos-veritone
force-pushed
the
feature/vtn-29032
branch
from
c51926f
to
6e5411f
Compare
| Run(ctx context.Context, req *Request, resp interface{}) error | ||
| SetLogger(func(string)) | ||
| } | ||
|
|
||
| // Client is a client for interacting with a GraphQL API. |
There was a problem hiding this comment.
This comment should be describing the interface on line 51
There was a problem hiding this comment.
Unfortunately, I didn't catch your comment prior to the merge. I would prefer deleting something as obvious as this.
quynhdang-vt
reviewed
Sep 5, 2019
| @@ -48,25 +48,26 @@ import ( | |||
| "github.com/pkg/errors" | |||
| ) | |||
|
|
|||
| type Client interface { | |||
There was a problem hiding this comment.
This change caused a problem in my repo where I was using a * to graphql.Client...!!
There was a problem hiding this comment.
Same issue with edge-output-writer https://github.com/veritone/edge-output-writer/blob/master/api/graphql.go#L78 where I was using
There was a problem hiding this comment.
The clients of graphql need to be updated to use the new API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTN-29032
This is to allow us to use mocks in the Core API layer of Edge services.