Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/politicians get #50

Merged
merged 7 commits into from Jul 9, 2017
Merged

Feature/politicians get #50

merged 7 commits into from Jul 9, 2017

Conversation

Ragnar-H
Copy link
Collaborator

@Ragnar-H Ragnar-H commented Jul 8, 2017

Requires a fresh DB. Make sure you delete your current one馃挘

Status

Ready

Description

Parliamentmembers now inherit from the Politician model.
The reasoning being that Politicians don't need to be Parliament Members.

Testing

Make sure initial_data.json is loaded.
Call GET localhost:8000/api/v1/politicians/

@Ragnar-H
Copy link
Collaborator Author

Ragnar-H commented Jul 8, 2017

@AriHrannar
Copy link
Contributor

Seems to be because of linting

$ pylint */*.py
************* Module parliament.models
C: 15, 0: Final newline missing (missing-final-newline)
************* Module politicians.admin
W:  1, 0: Unused admin imported from django.contrib (unused-import)
************* Module politicians.serializers
C: 21, 0: Trailing newlines (trailing-newlines)
C:  3, 0: external import "from party.serializers import PartySerializerRead" comes before "from .models import Politician" (wrong-import-order)
C:  4, 0: external import "from district.serializers import DistrictSerializer" comes before "from .models import Politician" (wrong-import-order)
C:  5, 0: external import "from promises.serializers import PromiseSerializerRead" comes before "from .models import Politician" (wrong-import-order)
************* Module politicians.tests
W:  1, 0: Unused TestCase imported from django.test (unused-import)
************* Module politicians.views
C: 16, 0: Trailing newlines (trailing-newlines)
W:  1, 0: Unused status imported from rest_framework (unused-import)
C:  6, 0: external import "from rest_framework.permissions import IsAuthenticatedOrReadOnly" comes before "from .models import Politician" (wrong-import-order)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c994ac1 on feature/politicians-get into ** on master**.

Copy link
Contributor

@AriHrannar AriHrannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ragnar-H Ragnar-H merged commit 81f9e43 into master Jul 9, 2017
@Ragnar-H Ragnar-H deleted the feature/politicians-get branch July 9, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants