Declare missing volumeClaimTemplate fields to fix ArgoCD ServerSideApply OutOfSync #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ioolkos
approved these changes
Feb 7, 2023
ioolkos
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When deploying VerneMQ using ArgoCD we run into the issue that the live manifest for the StatefulSet is different from the desired manifest when deploying a volume. ArgoCD then declares the app OutOfSync. This is caused by the missing optional fields
apiVersionandkindwhich are not defined in the Helm chart and ServerSideApply is used.Adding those two fields shouldn't have any other effect but would help people using ArgoCD.
Upstream Issue:
ServerSideApply=trueargoproj/argo-cd#11143