Handle retained bit in the bridge (vmq_bridge) #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshesel
force-pushed
the
handle-retain-bit-in-vmq-bridge
branch
from
7aa1096
to
736e936
Compare
|
@dergraf ready to merge? |
|
Dialyzer reports issues... otherwise LGTM |
larshesel
force-pushed
the
handle-retain-bit-in-vmq-bridge
branch
from
736e936
to
fa9e7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1223
I'm not sure why we didn't forward the retain bits before - to me it looks like an oversight. Note that this PR changes the
gen_mqtt_clientbehaviour callback definition for thepublishfunction.I think this is a bug, I've therefore included it into the 1.8.1 milestone.