Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces two new vmq-admin commands: disconnect clients and disconnect batch #2181

Merged
merged 1 commit into from Aug 24, 2023

Conversation

mths1
Copy link
Contributor

@mths1 mths1 commented Aug 7, 2023

Proposed Changes

Introduces two more vmq-admin commands disconnect clients and disconnect batch.
[
"vmq-admin session disconnect clients client-ids=\n\n",
" Forcefully disconnects a number of clients from the cluster. \n\n",
" --mountpoint=, -m\n",
" specifies the mountpoint, defaults to the default mountpoint\n",
" --cleanup, -c\n",
" removes the stored cluster state of this client like stored\n",
" messages and subscriptions.",
"\n\n"
].

vmq_session_disconnect_batch_usage() ->
[
"vmq-admin session disconnect batch count=Number of clients to be disconnected\n\n",
" Forcefully disconnects a number of (random) clients from the cluster. \n\n",
" --mountpoint=, -m\n",
" specifies the mountpoint, defaults to the default mountpoint\n",
" --cleanup, -c\n",
" removes the stored cluster state of this client like stored\n",
" messages and subscriptions.\n",
" --filter-client-ids=, -f\n"
" the clients will be filterd and not disconnected from the cluster\n",
"\n\n"

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@ioolkos
Copy link
Contributor

ioolkos commented Aug 7, 2023

Oh, nice idea for the batch disconnect with a keep filter!

@mths1
Copy link
Contributor Author

mths1 commented Aug 7, 2023

added a
" --node=, -n\n"
" limits disconnects to certain nodes\n",

actually vmq_ql is quite handy for such kinds of things...

@mths1 mths1 force-pushed the feature/batch-disconnect branch 2 times, most recently from debb68e to 6b74f2c Compare August 10, 2023 10:23
@mths1 mths1 marked this pull request as ready for review August 10, 2023 11:01
@goldyfruit
Copy link
Contributor

This is a really nice feature, thanks @mths1 👍

…t allows to disconnect a comma-separeted list of clients and disconnect batch which allows to disconnect a number of (random) clients
@ioolkos ioolkos merged commit ea95cb9 into vernemq:main Aug 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants