Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for systemd notify (start, watchdog) #2182

Merged
merged 2 commits into from Jan 2, 2024

Conversation

mths1
Copy link
Contributor

@mths1 mths1 commented Aug 13, 2023

Proposed Changes

systemd support is currently not optimal. As described in #1514 it is possible that systemd does not recognize a state change and thus e.g. does not restart the service accordingly. This change proposes:

  • Use systemd library to support "notify" service type
  • Change the mainpid to run_erl (supervises) by systemd
  • Use systemd-notify instead of pid files

Example system-d unit:

systemd unit file

[Unit]
Description=VerneMQ Server

[Service]
Type=notify
NotifyAccess=all
LimitNOFILE=100000
SuccessExitStatus=1
[...]
WatchdogSec = 30s
Restart = always

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue SystemD service is not align with VerneMQ state #1514 )
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@ioolkos
Copy link
Contributor

ioolkos commented Aug 13, 2023

Cool stuff, thanks! I wonder whether we could use this to have some cheap "boot states" instead of just "ready". (think "listeners started", "subscriptions loaded").

@mths1
Copy link
Contributor Author

mths1 commented Aug 13, 2023

systemd allows to set any status (here "custom status"). We would just need to know where to set the information and if it is ok to just have the latest status there indefinately or find a good place to really signal boot complete.

grafik

@ioolkos
Copy link
Contributor

ioolkos commented Aug 15, 2023

@mths1 I see, I'm looking into what makes sense to add.

@mths1 mths1 marked this pull request as ready for review September 23, 2023 15:05
@mths1 mths1 force-pushed the feature/systemd-notify branch 4 times, most recently from 4f5ea2c to 66b14fa Compare November 26, 2023 20:59
@mths1
Copy link
Contributor Author

mths1 commented Nov 29, 2023

@ioolkos : This should be "good enough" as a first version. There surely is room for improvement, but I am currently not working on this active anymore

@ioolkos ioolkos merged commit 582832e into vernemq:main Jan 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants