Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tls show command #2216

Merged
merged 1 commit into from Nov 22, 2023
Merged

Conversation

mths1
Copy link
Contributor

@mths1 mths1 commented Nov 20, 2023

Introduce tls show command, that allows to see information about installed certificates in particular the valid date.

Usage:
tls show
tls check -> reports certificates that expire soon.

Proposed Changes

Please describe the big picture of your changes here to communicate to the
VerneMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@mths1 mths1 marked this pull request as draft November 20, 2023 00:08
@mths1 mths1 force-pushed the feature/vmq_admin_cert_info branch 4 times, most recently from b2acb07 to 0753fc5 Compare November 20, 2023 13:29
…alled certificates in particular the valid date.
@mths1 mths1 force-pushed the feature/vmq_admin_cert_info branch from 0753fc5 to 3fe437a Compare November 20, 2023 13:32
@mths1 mths1 marked this pull request as ready for review November 20, 2023 17:42
Copy link
Contributor

@ioolkos ioolkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking for a minute why check and show are not somehow combined. Anyway, it gets the job done as is, so I have no change requests.

@ioolkos ioolkos merged commit 2cb946b into vernemq:main Nov 22, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants