Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to on_deliver hook, so that it can be used also for v3 clients #2256

Merged
merged 1 commit into from Feb 19, 2024

Conversation

mths1
Copy link
Contributor

@mths1 mths1 commented Feb 15, 2024

Add properties to on_deliver hook, so that it can be used also for v3 clients

Proposed Changes

Please describe the big picture of your changes here to communicate to the
VerneMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@ioolkos
Copy link
Contributor

ioolkos commented Feb 15, 2024

@mths1 interesting... what use case do you have in mind?

@mths1
Copy link
Contributor Author

mths1 commented Feb 16, 2024

As discussed it is more or less the same use-case as described here already: #1098

@mths1 mths1 force-pushed the feature/on_deliver_with_props branch 3 times, most recently from f5d2200 to 430be3f Compare February 17, 2024 09:20
@mths1
Copy link
Contributor Author

mths1 commented Feb 17, 2024

Seems to be good now. Needs a little change to vernemq_dev before it is really finished.

@ioolkos ioolkos marked this pull request as ready for review February 17, 2024 10:09
@ioolkos ioolkos force-pushed the feature/on_deliver_with_props branch from 430be3f to f4ab156 Compare February 19, 2024 12:47
@ioolkos ioolkos merged commit af957d5 into vernemq:main Feb 19, 2024
8 of 10 checks passed
@ioolkos
Copy link
Contributor

ioolkos commented Feb 20, 2024

@mths1 do you have a PR for vernemq_dev, or should I do it?

@mths1
Copy link
Contributor Author

mths1 commented Feb 20, 2024

Didn't see that you already merged. We also need to uncomment the following once the vernemq_dev change is done. I'll prepare a pull request (for both):

%-behaviour(on_deliver_hook).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants