Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use Rancher 2.5.9 #1365

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Update to use Rancher 2.5.9 #1365

merged 4 commits into from
Jul 20, 2021

Conversation

desagar
Copy link
Contributor

@desagar desagar commented Jul 20, 2021 •
edited

Description

Update verrazzano-bom to use Rancher 2.5.9. Also update additional_rancher images in the bom file for private registry install. Fix uninstall to clean up additional rolebindings and mutating webhook added in this version of Rancher.

Fixes VZ-3085

Checklist

As the author of this PR, I have:

  • Checked that I included or updated copyright and license notices in all files that I altered
  • Added or updated unit tests for any new functions I added
  • Added or updated integration tests if appropriate
  • Added or updated acceptance tests if appropriate

Code reviewer, please confirm this PR:

  • Addressed the requirement and meets the acceptance criteria
  • Does not introduce unrelated or spurious changes
  • Does not introduce any unapproved dependency
  • Makes sense and it easy to understand, and/or difficult areas of code are clearly documented so that they can be understood

kminder
kminder approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@kminder kminder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@desagar desagar merged commit 17e2cfa into master Jul 20, 2021
@desagar desagar deleted the desagar/VZ-3085 branch July 20, 2021 22:01
kminder pushed a commit that referenced this pull request Jul 20, 2021
@desagar @kminder
Update to use Rancher 2.5.9 (#1365)
94855fa 
* Update BOM and additional rancher images for private registry
* Fix uninstall to remove additional rolebindings and MutatingWebhookConfiguration created by this version of Rancher
markxnelson pushed a commit that referenced this pull request Jul 21, 2021
@kminder @desagar
Update to use Rancher 2.5.9 (#1365) (#1367)
309dcc3 
* Update BOM and additional rancher images for private registry
* Fix uninstall to remove additional rolebindings and MutatingWebhookConfiguration created by this version of Rancher

Co-authored-by: Deva Sagar <deva.sagar@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminder kminder kminder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@desagar @kminder