Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket field in Demo registration doesn't override the default #1

Closed
jamesmortensen opened this issue Oct 1, 2012 · 11 comments
Closed

Comments

@jamesmortensen
Copy link

I tried out your demo and noticed that when I put in my ws:// url into your textbox, the system still tried to connect to YOUR WebSocket server.

In the console log, in the Network tab in Chrome, you can see the ws url to tryit.jssip.net:10080

I had to go into /demos/tryit/js/init.js on line 7 and hard-code my own WS url in place of yours.

@ibc
Copy link
Member

ibc commented Oct 2, 2012

Yes, that's a bug in the demo code. We will address it soon.

@jmillan
Copy link
Member

jmillan commented Oct 2, 2012

James,

WebSocket field does now honor it's content. Beware that 'wss' schema is allowed in this demo. Thanks.

@jmillan
Copy link
Member

jmillan commented Oct 2, 2012

Sorry, there is a typo in the previous comment. 'wss' schema is NOT allowed in this demo.

@saghul
Copy link
Contributor

saghul commented Oct 2, 2012

@jmillan Why not?

@ibc
Copy link
Member

ibc commented Oct 2, 2012

AFAIR currently the secure transport option is a separate config option. Remember the discussion: Should we accept that the user configures N WebSocket URI's somw of them with WS schema and others with WSS? IMHO security should be a global option.

@saghul
Copy link
Contributor

saghul commented Oct 2, 2012

@ibc This is not about security, some parameters affect the whole outbound proxy set and others just each record. We need to revisit this.

@jmillan
Copy link
Member

jmillan commented Oct 2, 2012

@saghul The 'secure_transport' config parameter is not a seteable parameter in this demo. You could set it in the web sources. That was what I meant.

@goncaloazevedo
Copy link

hi, i am new at this SIP-JS roads !!!! i have an asterisk server configured but i didn't get how to connect jsSIP to my asterisk server! i get all the time "connected" but when i go to asterisk i see that is not true there are no clients connected.... so i think maybe i am doing something wrong!!! can someone help me?!?!

@jmillan
Copy link
Member

jmillan commented Oct 2, 2012

@goncaloazevedo - www.jssip.net is being prepared with the proper documentation in order to test JsSIP. It's going to be out in the coming days. There is also a googlegroup (email list) where you could address your question: https://groups.google.com/forum/?fromgroups#!forum/jssip.

regards

@ibc
Copy link
Member

ibc commented Oct 2, 2012

@goncaloazevedo, please update your git repository. The JsSIP demo page has been fixed today so now setting your own WS URI in the login box will make JsSIP to connect to that address (insted of the default one in tryit.jssip.net).

@jmillan
Copy link
Member

jmillan commented Oct 2, 2012

Fixed in ea0b054

@jmillan jmillan closed this as completed Oct 2, 2012
ibc pushed a commit that referenced this issue Feb 5, 2016
Fix test w/ correct parser output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants