Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explicit codec selection #164

Merged
merged 2 commits into from Jan 17, 2024
Merged

Fix explicit codec selection #164

merged 2 commits into from Jan 17, 2024

Conversation

fedulvtubudul
Copy link
Contributor

@fedulvtubudul fedulvtubudul commented Aug 1, 2023 •
edited

Fixes #163

@fedulvtubudul fedulvtubudul changed the title Fix explicit codec selection (#163) Fix explicit codec selection Aug 1, 2023
ibc
ibc reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this what we do in the JavaScript library to make codec selection work? AFAIR it's not.

@jmillan
Copy link
Member

jmillan commented Aug 1, 2023

If this what we do in the JavaScript library to make codec selection work? AFAIR it's not.

This change was made in mediasoup-client in this exact commit: versatica/mediasoup-client@8aec3ac

This PR does partially implement it.

@fedulvtubudul
Copy link
Contributor Author

fedulvtubudul commented Aug 2, 2023 •
edited

Most of the work was done years ago in this commit: 6e30a33. codec parameter was added, but the mechanism did not work properly because of the implementation details in getSendingRtpParameters, which always returned a single codec (the first one with matching media kind).

It was the same in TS implementation (using first codec with matching kind) before the commit versatica/mediasoup-client@8aec3ac that @jmillan has mentioned.

@jmillan jmillan merged commit f7e732c into versatica:v3 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendTransport::Produce(...) codec parameter is ignored
3 participants
@fedulvtubudul @jmillan @ibc