Skip to content

Commit

Permalink
Be ready for numeric codec parameters exposed as strings in Edge (rel…
Browse files Browse the repository at this point in the history
…ated to #15)
  • Loading branch information
ibc committed Jan 22, 2018
1 parent e4e8606 commit 094601f
Show file tree
Hide file tree
Showing 4 changed files with 572 additions and 457 deletions.
2 changes: 1 addition & 1 deletion dist/mediasoup-client.js

Large diffs are not rendered by default.

14 changes: 11 additions & 3 deletions lib/handlers/ortc/edgeUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,17 @@ export function getCapabilities()
// Add mimeType.
codec.mimeType = `${codec.kind}/${codec.name}`;

// NOTE: Edge sets parameters.apt as String rather than Number. Fix it.
if (codec.name === 'rtx')
codec.parameters.apt = Number(codec.parameters.apt);
// NOTE: Edge sets some numeric parameters as String rather than Number. Fix them.
if (codec.parameters)
{
const parameters = codec.parameters;

if (parameters.apt)
parameters.apt = Number(parameters.apt);

if (parameters['packetization-mode'])
parameters['packetization-mode'] = Number(parameters['packetization-mode']);
}

// Delete emty parameter String in rtcpFeedback.
for (const feedback of codec.rtcpFeedback || [])
Expand Down
Loading

0 comments on commit 094601f

Please sign in to comment.