New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native producer localId is null #263
Labels
Comments
quanli168
changed the title
React Native producer localId is undefined
React Native producer localId is null
Jun 8, 2023
ibc
added a commit
that referenced
this issue
Jun 23, 2023
…tc 111 on iOS (unset transceiver.mid) - Fixes issue #263 - Replaces PR #264 - Issue in react-native-webrtc: react-native-webrtc/react-native-webrtc#1404 ### Details - `ReactNativeWithUnifiedPlan`: Read `transceiver.mid` after calling `pc.setRemoteDescription()` since it's set then (and not before, bug in react-native-webrtc). - Problem of this approach is that we are generating the remote SDP without MID (since we don't know it yet). Not sure about the implications. I'm pretty sure that the new media section in the SDP **does** contain proper `a=mid` (it's just that `transceiver.mid` returns `null`), and in this PR we are calling `setRemoteDescription()` with a remote media section that doesn't contain `a=mid`.
ibc
added a commit
that referenced
this issue
Jun 23, 2023
…tc 111 on iOS (unset transceiver.mid) (#271) - Fixes issue #263 - Replaces PR #264 - Issue in react-native-webrtc: react-native-webrtc/react-native-webrtc#1404 ### Details - `ReactNativeWithUnifiedPlan`: Read `transceiver.mid` after calling `pc.setRemoteDescription()` since it's set then (and not before, bug in react-native-webrtc). - Problem of this approach is that we are generating the remote SDP without MID (since we don't know it yet). Not sure about the implications. I'm pretty sure that the new media section in the SDP **does** contain proper `a=mid` (it's just that `transceiver.mid` returns `null`), and in this PR we are calling `setRemoteDescription()` with a remote media section that doesn't contain `a=mid`.
Fix released in mediasoup-client 3.6.88 |
But better use mediasoup-client 3.6.89 which contains this improvement react-native-webrtc/react-native-webrtc#1404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
IMPORTANT: We primarily use GitHub as an issue tracker. Just open an issue here if you have encountered a bug in mediasoup-client.
If you have questions or doubts about mediasoup-client or need support, please use the mediasoup Discourse Group instead:
https://mediasoup.discourse.group
Your environment
Issue description
Producing client starts with producing both audio and video, then calls producer.close() for audio, but video producer is stopped.
Produce audio (note audio track
mid
is 0)Produce video (note video track
mid
is 1)Stop producing audio (note
localId
passed tostopSending
is null, andmid
1 is turned off)I believe the issue is in
ReactNativeUnifiedPlan.send()
,transceiver.mid
is not set aftersetLocalDescription(offer)
, it is only set after callingsetRemoteDescription(answer)
.The text was updated successfully, but these errors were encountered: