Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox120 handler #295

Merged
merged 3 commits into from Feb 29, 2024
Merged

Add Firefox120 handler #295

merged 3 commits into from Feb 29, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Feb 29, 2024

Details

  • Fixes Cannot change the number of encodings with setParameters #293
  • Basically the only change is that it passes sendEncodings in pc.addTransceivers() (as per spec) rather than having to set encodings later via sender.setParameters(), which was a hack in previous Firefox versions.
  • Cosmetic change in Chrome111 since encoding.rid was set twice.

### Details

- Fixes #293
- Basically the only change is that it passes `sendEncodings` in `pc.addTransceivers()` (as per spec) rather than having to set encodings later via `sender.setParameters()`, which was a hack in previous Firefox versions.
- Cosmetic change in `Chrome111` since `encoding.rid` was set twice.
@ibc ibc merged commit d4c021f into v3 Feb 29, 2024
@ibc ibc deleted the add-firefox-handler-120 branch February 29, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change the number of encodings with setParameters
1 participant