Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need kernel 6 capable Linux CI host to produce worker prebuilt with io-uring support #1284

Closed
ibc opened this issue Dec 30, 2023 · 1 comment · Fixed by #1300
Closed

Need kernel 6 capable Linux CI host to produce worker prebuilt with io-uring support #1284

ibc opened this issue Dec 30, 2023 · 1 comment · Fixed by #1300
Labels
CI GitHub CI actions enhancement
Milestone

Comments

@ibc
Copy link
Member

ibc commented Dec 30, 2023

Related to PR #1283 "mediasoup-worker linux prebuilt with io-uring support (part 1)".

Details

In mediasoup-worker-prebuild CI job we are using an old Ubuntu version 20.04 to create the Linux mediasoup-worker prebuilt binary (for reasons as documented inline). Problem is that Ubuntu 20.04 uses kernel 5.15 (<6) so we are not enabling io-uring on these binaries :(

# For Linux let's use an old version of Ubuntu (20.04) that builds the
# mediasoup-worker binary using an old version of GLib, so it will work
# on Linux hosts running more modern GLib versions.
# See https://github.com/versatica/mediasoup/issues/1089.
- os: ubuntu-20.04
  cc: gcc
  cxx: g++
- os: macos-12
  cc: clang
  cxx: clang++
- os: windows-2022
  cc: cl
  cxx: cl

Problem is that Ubuntu 22.05 also comes with Kernel 5.15, so it's not a valid option. Once GH actions include Ubuntu 24.05 (I assume with kernel 6) we must include it in the job.

NOTE: When that is done we must still keep Ubuntu 20.04 since, as documented in the job file, it uses an old version of GLib which is needed in systems with GLib equal or newer than that (the opposite is not true: a software built with a modern version of GLib cannot run in systems with an older GLib version). If we don't do this we'd run into this issue again: #1089.

@ibc ibc added this to the v3 updates milestone Dec 30, 2023
@ibc ibc changed the title Need kernel 6 capable Linux CI host to produce prebuilt worker with io-uring Need kernel 6 capable Linux CI host to produce worker prebuilt with io-uring support Dec 30, 2023
@ibc ibc added enhancement CI GitHub CI actions labels Dec 30, 2023
@ibc
Copy link
Member Author

ibc commented Jan 5, 2024

Oh, it looks like Ubuntu 22.04 in GitHub CI does use Kernel 6!!!

CleanShot-2024-01-05-at-10 45 31@2x

https://github.com/versatica/mediasoup/actions/runs/7420306782/job/20191434155

ibc added a commit that referenced this issue Jan 5, 2024
Fixes #1284

### Details

- Ubuntu 22.04.3 LTS has kernel 6.2.
- CI job: No need to manually install `invoke` since `npm run worker:build` internally installs it if needed.
@ibc ibc closed this as completed in #1300 Jan 5, 2024
ibc added a commit that referenced this issue Jan 5, 2024
Fixes #1284

### Details

- Ubuntu 22.04.3 LTS has kernel 6.2.
- CI job: No need to manually install `invoke` since `npm run worker:build` internally installs it if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GitHub CI actions enhancement
Development

Successfully merging a pull request may close this issue.

1 participant