Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jitter calculation in RtpStreamRecv #1117

Merged
merged 4 commits into from Jul 12, 2023
Merged

Fix jitter calculation in RtpStreamRecv #1117

merged 4 commits into from Jul 12, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Jul 12, 2023 •
edited

  • Inspired by PR fix jitter in rr #1108.
  • Calculate jitter in RTP timestamp units (as per spec) rather than milliseconds.
  • Also, and as per spec, make this->jitter be a float despite we convert it to uint32_t when generating stats.

@ibc
Fix jitter calculation in RtpStreamRecv
b169f2a 
- Inspired by PR #1108.
- Calculate `jitter` in RTP timestamp units (as per spec) rather than milliseconds.
@ibc ibc mentioned this pull request Jul 12, 2023
Closed
@ibc ibc requested a review from jmillan July 12, 2023 11:37
@ibc ibc added this to the v3 updates milestone Jul 12, 2023
@ibc ibc merged commit 5d31b53 into v3 Jul 12, 2023
29 checks passed
@ibc ibc deleted the fix-jitter-calculation-in-rtpstreamrecv branch July 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmillan jmillan jmillan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v3 updates
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibc @jmillan