Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBS: normalize FBS types #1159

Merged
merged 5 commits into from
Sep 19, 2023
Merged

FBS: normalize FBS types #1159

merged 5 commits into from
Sep 19, 2023

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Sep 15, 2023

Use aliases for Message, Request and Notification bodies.

Needed for Rust[*], plus the resulting type names are much more convenient, which remove the redundant 'FBS_' prefix.

[*] (planus-org/planus#180).

NOTE: This PR is based on #1158 and will be merged once the former is accepted and merged.

Use aliases for Message, Request and Notification bodies.

Needed for Rust[*], plus the resulting type names are much more
convenient, which come with the redundant 'FBS_' prefix.

[*] (planus-org/planus#180).
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

Base automatically changed from fbs_transport_events to flatbuffers September 19, 2023 10:33
* FBS: format schemas

Using planus formatter

* FBS: type for RtpHeaderExtensionUri (#1161)
@jmillan jmillan merged commit d57e3b0 into flatbuffers Sep 19, 2023
30 checks passed
@jmillan jmillan deleted the fbs_normalize_body_types branch September 19, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants