Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use given PYTHON env variable (if given) when running worker/scripts/getmake.py #1186

Merged
merged 2 commits into from Oct 19, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Oct 19, 2023

Just that.

@ibc ibc requested review from jmillan and nazar-pc October 19, 2023 14:28
@ibc
Copy link
Member Author

ibc commented Oct 19, 2023

@nazar-pc I assume we need this also for Rust (although I don't see that Rust code calls getmake.py at all).

@ibc ibc merged commit acf7a56 into v3 Oct 19, 2023
18 checks passed
@ibc ibc deleted the use-given-python-env-for-getmake.py branch October 19, 2023 14:45
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this useful?

@ibc
Copy link
Member Author

ibc commented Oct 19, 2023

When is this useful?

When you are desperate asking workmates to test the installation of mediasoup in Windows to debug #1179 and they need to pass a specific python path because the python they have in the PATH is a link to somewhere else and somehow in Windows links do not work as nicely as in *nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants