Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBS: LayersChangeNotification body must be optional #1227

Merged
merged 3 commits into from Nov 17, 2023

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Nov 17, 2023

It's none when the spatial layer is -1 internally.

This was crashing the worker when trying to create an empty notification, since the schema was requiring the body.

It's none when the spatial layer is -1 internally.
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layers notification without layers makes little sense to me 🤔

@jmillan
Copy link
Member Author

jmillan commented Nov 17, 2023

Yes, same here. But layers are represented by positive numbers. The absence of a positive layer means no layer.

We could make the body mandatory and both fields spatialLayer and temporalLayer optional though.

CHANGELOG.md Outdated Show resolved Hide resolved
@ibc
Copy link
Member

ibc commented Nov 17, 2023

Yes, same here. But layers are represented by positive numbers. The absence of a positive layer means no layer.

We could make the body mandatory and both fields spatialLayer and temporalLayer optional though.

we emit null to the user anyway so I don't see the point in notifying with undefined/null layers to Node/Rust to make them emit null.

@ibc ibc merged commit f88f68e into v3 Nov 17, 2023
35 checks passed
@ibc ibc deleted the fbs-LayersChangeNotification branch November 17, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants