Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust DataConsumer #1262

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Fix Rust DataConsumer #1262

merged 9 commits into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. Fix Rust DataConsumer 

    ### Details

* [x] Rust `set_subchannels()` method was only implemented in `DirectDataConsumer` which is wrong.
* [ ] Rust `DirectDataConsumer` lacks ALL methods of `DataConsumer` such as `pause()`, `closed()`, etc!!!
* [x] Bonus track: Use an ordered set in `DataConsumer` in worker so `subchannels` will be always shown in numerical order (no need to sort them later in Node/Rust layer).
    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    aca18a3 View commit details
    Browse the repository at this point in the history

  2. add "subchannels" to debug of RegularDataConsumer

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5a0cc38 View commit details
    Browse the repository at this point in the history

  3. directly use DataConsumer in test 

    Rather than DirectDataConsumer.
    @jmillan
    jmillan committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    449a7e1 View commit details
    Browse the repository at this point in the history

  4. Fix remaining things

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e8a4261 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2328829 View commit details
    Browse the repository at this point in the history

  6. Revert usage of absl ordered set since it sorts... by string!!!

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1592bbf View commit details
    Browse the repository at this point in the history

  7. Update CHANGELOG

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d7a038d View commit details
    Browse the repository at this point in the history

  8. Fix node tests

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    712c930 View commit details
    Browse the repository at this point in the history

  9. and fix rust test

    @ibc
    ibc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2b3e88f View commit details
    Browse the repository at this point in the history