Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liburing zero copy #1273

Merged
merged 11 commits into from
Dec 22, 2023
Merged

liburing zero copy #1273

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1277f5c
liburing zero copy
jmillan Dec 19, 2023
8841ec4
handle feedback
jmillan Dec 19, 2023
7fa3e96
handle ENOMEM error when registering buffers
jmillan Dec 20, 2023
47bc490
fix error comparison
jmillan Dec 21, 2023
2d5a906
Merge branch 'v3' into liburing_zc
ibc Dec 22, 2023
f5ae4c3
Cosmetic
ibc Dec 22, 2023
239cebf
Merge branch 'v3' into liburing_zc
ibc Dec 22, 2023
b861aa9
Try to make compiled happy
ibc Dec 22, 2023
7a6e7ee
Do not use errno variable name
ibc Dec 22, 2023
230f4bc
Use error = -1 * err everywhere
ibc Dec 22, 2023
4c9895b
remove uneeded '-1 *' to negate an int
jmillan Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions worker/src/DepLibUring.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,15 +313,15 @@ DepLibUring::LibUring::LibUring()

if (err < 0)
{
int errno = -err;
int errno = -1 * err;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here seems the variable name. It's not a good idea using errno as a local variable as the compiler threats it specially (see the compiling errors.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this file is using -err in other places for logging purposes, so this change is generating an inconsistency across the file.

Copy link
Member

@ibc ibc Dec 22, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done to make it consistent.


if (errno == ENOMEM)
{
this->zeroCopyEnabled = false;

MS_WARN_TAG(
info,
"io_uring_register_buffers() failed due to low memlock limit (ulimit -l), disabling zero copy",
"io_uring_register_buffers() failed due to low memlock limit (ulimit -l), disabling zero copy: %s",
std::strerror(errno));
}
else
Expand Down