Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Really run fuzzer for 5 minutes #1338

Merged
merged 11 commits into from
Feb 21, 2024
Merged

CI: Really run fuzzer for 5 minutes #1338

merged 11 commits into from
Feb 21, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Feb 20, 2024

Run invoke fuzzer-run-all and wait for 5 minutes. Then check if it was still running. If not it means that it existed due to some (fuzzer) error so CI would fail.

NOTE: This was not needed finally but just in case, the fuzzer binary exists with status 77 if a fuzzer issue happened and with status 72 (internally documented) if interrupted via SIGINT. Docs: https://llvm.org/docs/LibFuzzer.html

Bonus Track: Fix #1334.
Bonus Track: Fix #1335.

@ibc ibc requested review from jmillan and nazar-pc February 20, 2024 11:24
@ibc
Copy link
Member Author

ibc commented Feb 20, 2024

NOTE: I'm doing improvements.

@ibc
Copy link
Member Author

ibc commented Feb 20, 2024

Funny thing is that this PR is blocked by #1335 :(

@ibc
Copy link
Member Author

ibc commented Feb 20, 2024

The run-fuzzer.sh script is much better now and it doesn't wait given "duration" before it checks if fuzzer keeps running or not. It monitor it every minute.

What would you think could be a good duration for this CI? 2 minutes is obviously very little.

@jmillan
Copy link
Member

jmillan commented Feb 20, 2024

What would you think could be a good duration for this CI? 2 minutes is obviously very little.

I think 2 minutes would detect most of the issues indeed.

@ibc
Copy link
Member Author

ibc commented Feb 20, 2024

Really? I thought 2 minutes is too little...

@ibc
Copy link
Member Author

ibc commented Feb 20, 2024

Let me please increase it to 5 minutes.

@ibc ibc linked an issue Feb 20, 2024 that may be closed by this pull request
@ibc ibc changed the title CI: Really run fuzzer for 2 minutes CI: Really run fuzzer for 5 minutes Feb 20, 2024
@jmillan
Copy link
Member

jmillan commented Feb 21, 2024

@ibc, in order to run the fuzzer this must be run:

MESON_ARGS="-Dms_disable_liburing=true -Db_sanitize=address" make fuzzer
make fuzzer-run-all

The b_sanitize option makes the job adding the required CPP and link args accordingly.

@ibc
Copy link
Member Author

ibc commented Feb 21, 2024

I've read the comments in meson PR. So those args should be added in fuzzer_run_all task in worker/tasks.py right?

@ibc
Copy link
Member Author

ibc commented Feb 21, 2024

Working fine. Merging.

@ibc ibc merged commit 74934de into v3 Feb 21, 2024
23 checks passed
@ibc ibc deleted the ci-really-run-fuzzer branch February 21, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants