Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codecs (related to #306) #308

Merged
merged 5 commits into from
May 27, 2019
Merged

Improve codecs (related to #306) #308

merged 5 commits into from
May 27, 2019

Conversation

ibc
Copy link
Member

@ibc ibc commented May 24, 2019

However, note that while in VP8::PayloadDescriptorHandler::Encode() we check whether pictureId is greater than highest seen, we don't have "picture Id" in H264, but just the tl0picidx. So I've implemented the same logic but by checking tl0picidx. I hope it's also valid.

- VP8: Check that the payload has pictureId and tl0PictureIndex before using them.
- H264: Check tl0picidx is greater than highest seen (related to #306).
@ibc
Copy link
Member Author

ibc commented May 27, 2019

NOTE: It strongly worries me the fact that we have a currentTemporalLayer in both SimulcastConsumer and EncodingContext classes, and they are not in sync but independently managed.

@jmillan
Copy link
Member

jmillan commented May 27, 2019

NOTE: It strongly worries me the fact that we have a currentTemporalLayer in both SimulcastConsumer and EncodingContext classes, and they are not in sync but independently managed.

Agreed, I think we could use the EncodingContext to set, get the current temporal layer from SimulcastConsumer

@ibc
Copy link
Member Author

ibc commented May 27, 2019

However, note that while in VP8::PayloadDescriptorHandler::Encode() we check whether pictureId is greater than highest seen, we don't have "picture Id" in H264, but just the tl0picidx. So I've implemented the same logic but by checking tl0picidx. I hope it's also valid.

And it was not valid so has been reverted. This was letting MOST of the packets pass. This is because many H264 packets with different tid have the same tl0picidx. So check removed.

@ibc ibc merged commit 13ac309 into v3 May 27, 2019
@ibc ibc deleted the codecs-improvement branch May 27, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants