Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript fixes #422

Merged
merged 4 commits into from Jun 11, 2020
Merged

TypeScript fixes #422

merged 4 commits into from Jun 11, 2020

Conversation

nazar-pc
Copy link
Collaborator

Minor tweaks from #416 that I believe are worth including, rationale is well described there

ibc
ibc reviewed Jun 11, 2020
View reviewed changes
src/WebRtcTransport.ts Outdated Show resolved Hide resolved
ibc
ibc reviewed Jun 11, 2020
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@ibc ibc merged commit 2e2b329 into versatica:v3 Jun 11, 2020
@ibc
Copy link
Member

ibc commented Jun 11, 2020

Thanks

@ibc
Copy link
Member

ibc commented Jun 11, 2020

Interesting: I've run npm run typescript:build and the new code under lib/ code does not even change.

@nazar-pc nazar-pc deleted the typescript-fixes branch June 11, 2020 13:26
@nazar-pc
Copy link
Collaborator Author

Because you were careful and didn't use anything unsupported in Node 10, so makes perfect sense.

@ibc
Copy link
Member

ibc commented Jun 11, 2020

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nazar-pc @ibc