Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sctp: notify consumer if send buffer is full #432

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Jul 9, 2020

And new maxSctpSendBufferSize transport option

And new maxSctpSendBufferSize transport option
src/Router.ts Show resolved Hide resolved
src/WebRtcTransport.ts Show resolved Hide resolved
@jmillan
Copy link
Member Author

jmillan commented Jul 9, 2020

NOTE:

	static size_t DefaultSctpSendBufferSize{ 262144 }; // 2^18.
	static size_t MaxSctpSendBufferSize{ 268435456 };  // 2^28.

I need to properly check those values. The first comes from the default value in my system, the second from a comment from heresctplab/usrsctp#142 (comment)

@ibc ibc merged commit dc2e128 into v3 Jul 9, 2020
@ibc ibc deleted the maxSctpSendBufferSize branch July 9, 2020 22:35
@ibc
Copy link
Member

ibc commented Jul 9, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/DataConsumer.js  1
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants