Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataChannel bufferedamount #442

Merged
merged 13 commits into from
Aug 4, 2020
Merged

DataChannel bufferedamount #442

merged 13 commits into from
Aug 4, 2020

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Aug 3, 2020

  • DataConsumer.getBufferedAmount() method
  • DataConsumer.bufferedAmountLowThreshold
  • DataConsumer 'bufferedamountlow' event

@jmillan
DataChannel bufferedamount
60afdf4 
* DataConsumer.getBufferedAmount() method
* DataConsumer 'bufferedamountlow' event
@jmillan jmillan requested a review from ibc August 3, 2020 16:56
ibc
ibc requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few issues.

worker/src/RTC/SctpAssociation.cpp Outdated Show resolved Hide resolved
worker/src/RTC/Transport.cpp Show resolved Hide resolved
ibc
ibc reviewed Aug 4, 2020
View reviewed changes
src/DataConsumer.ts Outdated Show resolved Hide resolved
ibc
ibc reviewed Aug 4, 2020
View reviewed changes
src/DataConsumer.ts Outdated Show resolved Hide resolved
@jmillan
Copy link
Member Author

jmillan commented Aug 4, 2020

This must also be removed from the docs: https://mediasoup.org/documentation/v3/mediasoup/api/#dataConsumer-observer-on-sctpsendbufferfull

Already done

@jmillan
Copy link
Member Author

jmillan commented Aug 4, 2020

deploying docs...

@ibc
Copy link
Member

ibc commented Aug 4, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/DataConsumer.js  3
         

Clones added
============
- lib/DataConsumer.js  1

See the complete overview on Codacy

@jmillan jmillan merged commit d6d692c into v3 Aug 4, 2020
@jmillan jmillan deleted the datachannel-bufferedamount branch August 4, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmillan @ibc