-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix miscalculation when increasing layer #541
Conversation
We should subtract the whole bitrate of provisional layer.
Please run Also, could you please detail the rationale of this change? I fail to see it. |
When we increse to a higher spatial layer, we need to know how mush additional bitrate is needed. |
You are 100% right. Thanks. Merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
releasing a new version in a few minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should subtract the whole bitrate of provisional layer when increasing to a higher spatial layer.