Rust support on macOS #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
May 28, 2021
ibc
approved these changes
May 28, 2021
|
ready to merge? and if so, anything else missing? can we release and announce "support for mediasoup Rust in macOS"? |
|
Yes, this is ready and let's get #568 in so I can publish a proper release. |
|
Released in mediasoup 3.7.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements macOS support in Rust crates and adds macOS to CI for Rust.
What it boils down to is that on macOS there is no static version of C++ standard library available out of the box, so build.rs will download LLVM 12.0.0 tarball and will extract
libc++.a+libc++abi.aand will link those into final mediasoup-sys library alongside with libmediasoup-worker itself.