Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove request timeouts from TypeScript #667

Merged
merged 1 commit into from Oct 9, 2021
Merged

Remove request timeouts from TypeScript #667

merged 1 commit into from Oct 9, 2021

Conversation

nazar-pc
Copy link
Collaborator

@nazar-pc nazar-pc commented Oct 9, 2021

As we discussed, it is not super useful since requests are not cancelled and will be processed by worker anyway

ibc
ibc approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll merge once CI passes (or feel free to do it if you see it passing before me)

@ibc ibc merged commit 0a4ab95 into versatica:v3 Oct 9, 2021
@nazar-pc nazar-pc deleted the remove-request-timeout-ts branch October 9, 2021 11:01
@nazar-pc nazar-pc mentioned this pull request Oct 10, 2021
Closed
@jmillan
Copy link
Member

jmillan commented Nov 8, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nazar-pc @jmillan @ibc