Transport: Hide debug message for RTX RTCP-RR packets #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be cool if this could be backported to mediasoup 3.8 too... 3.9 is too recent and we're still having some work to do with our Docker images to make it work with the new build system |
ibc
approved these changes
Oct 22, 2021
|
We cannot backport to 3.8.X, we don't maintain other 3.X.X versions, that would be too much work. I suggest not enabling DEBUG level in workers in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything was already in place, only a final check was needed to avoid printing a debug message when RTCP-RR packets are received from the RTX stream, which are not used for anything in mediasoup but should not cause a constant stream of debug lines either.
Related: https://mediasoup.discourse.group/t/no-consumer-found-for-received-receiver-report/3467