Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: add types for internal and data objects #891

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Node: add types for internal and data objects #891

merged 4 commits into from
Aug 23, 2022

Conversation

ibc
Copy link
Member

@ibc ibc commented Aug 23, 2022 •
edited

...and avoid tons of any types.

@ibc ibc requested a review from nazar-pc August 23, 2022 12:03
nazar-pc
nazar-pc approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly in favor of heavier typing 👍

nazar-pc
nazar-pc approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer 🙂

@ibc ibc merged commit f7d74e7 into v3 Aug 23, 2022
@ibc ibc deleted the node-add-types-for-internal branch August 23, 2022 14:29
piranna pushed a commit to dyte-in/mediasoup that referenced this pull request Feb 9, 2023
@ibc @piranna
Node: add types for internal and data objects (versatica#891)
d00bc47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibc @nazar-pc