Fix Rust support after recent changes #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
Aug 28, 2022
jmillan
approved these changes
Aug 29, 2022
|
Any chance to have this merged tomorrow morning? I'd like to make a release for Node and I assume we need another one for Rust. |
|
It is just the comments that are left. I'll try to write some within next few hours. |
|
I'll merge. Thanks for this. |
|
3.6.10 released |
|
Rust 0.11.0 is out too |
piranna
pushed a commit
to dyte-in/mediasoup
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit restores code unnecessarily removed in #893 without which Rust can't send anything to worker.
Second commit fixes Rust support after #893, there I had to change how requests and notifications look like a bit, as the result we have less code and it is a bit cleaner.
Third commit updates dump data structure and tests according to changes in #894.
Last commit bumps versions, dependencies and updates changelog so we can publish it.