Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of bufferedAmount value in JSON #936

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

nazar-pc
Copy link
Collaborator

Fixes #930, which is a regression introduced in #893 where value changed from being a number to a string.

@nazar-pc nazar-pc requested a review from ibc October 29, 2022 15:08
@nazar-pc nazar-pc force-pushed the fix-buffered-amount-low-json-type branch from 7565345 to 00d7569 Compare October 29, 2022 15:13
@nazar-pc nazar-pc changed the title Fix type of bufferedAmountLow value in JSON Fix type of bufferedAmount value in JSON Oct 29, 2022
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing that we are gonna get rid of JSON entirely soon...

@nazar-pc nazar-pc merged commit 6bb5fcd into versatica:v3 Oct 29, 2022
@nazar-pc nazar-pc deleted the fix-buffered-amount-low-json-type branch October 29, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse notification error with webrtc datachannel
2 participants