Skip to content

Commit

Permalink
4.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
ibc committed Feb 4, 2019
1 parent e49e225 commit c51bc1b
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 18 deletions.
11 changes: 11 additions & 0 deletions README.md
Expand Up @@ -12,6 +12,17 @@ Minimalist and extensible Node.js signaling framework for multi-party Real-Time
* [protoojs.org][protoo-website]


## Breaking changes in v4

* In **protoo-server**:
- `peer.send()` has been renamed to `peer.request()`.
- `room.createPeer()` is now `async` (so it returns a promise that resolves to a `Peer`).
- `room.spread()` method has been removed.

* In **protoo-client**:
- `peer.send()` has been renamed to `peer.request()`.


## Author

Iñaki Baz Castillo ([@ibc](https://github.com/ibc/) at Github)
Expand Down
15 changes: 1 addition & 14 deletions client/lib/Peer.js
Expand Up @@ -9,10 +9,9 @@ class Peer extends EnhancedEventEmitter
/**
* @param {protoo.Transport} transport
*
* @emits {currentAttempt: Number} connecting
* @emits open
* @emits {currentAttempt: Number} failed
* @emits disconnected
* @emits failed
* @emits close
* @emits {request: protoo.Request, accept: Function, reject: Function} request
* @emits {notification: protoo.Notification} notification
Expand Down Expand Up @@ -208,18 +207,6 @@ class Peer extends EnhancedEventEmitter
return;
}

this._transport.on('connecting', (currentAttempt) =>
{
if (this._closed)
return;

logger.debug('emit "connecting" [currentAttempt:%s]', currentAttempt);

this._connected = false;

this.safeEmit('connecting', currentAttempt);
});

this._transport.on('open', () =>
{
if (this._closed)
Expand Down
2 changes: 0 additions & 2 deletions client/lib/transports/WebSocketTransport.js
Expand Up @@ -120,8 +120,6 @@ class WebSocketTransport extends EnhancedEventEmitter
this._options.requestOptions,
this._options.clientConfig);

this.safeEmit('connecting', currentAttempt);

this._ws.onopen = () =>
{
if (this._closed)
Expand Down
2 changes: 1 addition & 1 deletion client/package.json
@@ -1,6 +1,6 @@
{
"name": "protoo-client",
"version": "4.0.0-dev",
"version": "4.0.0",
"description": "protoo JavaScript client module",
"author": "Iñaki Baz Castillo <ibc@aliax.net>",
"homepage": "https://protoojs.org",
Expand Down
2 changes: 1 addition & 1 deletion server/package.json
@@ -1,6 +1,6 @@
{
"name": "protoo-server",
"version": "4.0.0-dev",
"version": "4.0.0",
"description": "protoo Node.js server module",
"author": "Iñaki Baz Castillo <ibc@aliax.net>",
"homepage": "https://protoojs.org",
Expand Down

0 comments on commit c51bc1b

Please sign in to comment.