Add usrsctp_get_timeout() #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as PR sctplab#591 by @oleavr in upstream project which has been ignored for 4 years. A little change: Instead of using `int` to hold a `uint32_t` (or -1) let's use a `int64_t`.
ibc
added a commit
to versatica/mediasoup
that referenced
this pull request
Mar 5, 2024
### Details - Related task: #1011. Note that usrsctp author never cared about the existing PR so we are on our own. - So I've forked usrctp, added the `usrsctp_get_timeout()` feature and released version 0.9.6.0: versatica/usrsctp#1 - And I've made `usrsctp.wrap` point to it. ### Notes - It would be great to have a way to pass `sctp_debug=true` when building usrsctp Meson subproject so it defines `SCTP_DEBUG` (needed in `DepUsrSCTP.cpp` to show SCTP debug). An manual alternative is to edit `meson.build` of usrsctp and add it unconditionally. - I'm calling `HandleUsrSctpTimers()` everytime the timer fires (of course), also in `onSendSctpData` callback and also when SCTP data is received (in `SctpAssociation::ProcessSctpData()`. Not sure if correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR sctplab#591 by @oleavr in upstream project which has been ignored for 4 years.
A little change: Instead of using
intto hold auint32_t(or -1) let's use aint64_t.