Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO DO #14

Closed
10 of 12 tasks
Plajer opened this issue Nov 5, 2017 · 3 comments
Closed
10 of 12 tasks

TO DO #14

Plajer opened this issue Nov 5, 2017 · 3 comments

Comments

@Plajer
Copy link
Collaborator

Plajer commented Nov 5, 2017

Things to do for next pull request:

  • Decapitalise package names
  • Create files: signModification.yml, STATS.yml, SpecialItems.yml and Kits.yml from plugin jar (instead of that weird create file method from gameapi)
  • Create UpdateChecker class
  • Make plugin prefix (from ChatManager) configurable in language.yml (to do in LanguageMigrator class)
  • Add plugin prefixes for rest of messages that need them
  • *Make MessageHandler_v1x_xx_Rx classes reflection based (and merge them into 1 class)
  • Remove onKick listener from onQuit class (@TomtheCreator quit event is called after kick https://www.spigotmc.org/threads/is-playerquitevent-called-after-playerkickevent.267729/)
  • Rename onSpectate listeners in onSpectate class
  • Change lines 217-221 in Events class (useless)
  • Make translatable Spawn Wolf item (Events class)
  • Remove getLabel() checking from ChestCommands class (use getName() instead)
  • Remove is1x_xx_Rx from VillageDefense class (GameAPI class have this methods) + change methods from GameAPI class to return getVersion()... instead of if (getVersion()...) return true; return false;
@Plajer Plajer added this to the 2.1.0 milestone milestone Nov 5, 2017
@VerschuerenTom
Copy link
Owner

VerschuerenTom commented Nov 5, 2017

DO NOT capitalize package names. Why? ->
https://stackoverflow.com/questions/12534302/why-should-java-package-name-be-lowercase

@Plajer
Copy link
Collaborator Author

Plajer commented Nov 6, 2017

ok, changed 🥇

@Plajer
Copy link
Collaborator Author

Plajer commented Nov 13, 2017

Rest of things will be added in the future releases.

@Plajer Plajer closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants