Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window environment variables): wrong type of environment variable… #160

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

jan-bar
Copy link
Contributor

@jan-bar jan-bar commented Mar 31, 2024

… set

https://learn.microsoft.com/zh-cn/windows/win32/sysinfo/registry-value-types

according to the official window documentation,
when there is a variable to be expanded such as "%name%" in the environment variable, you need to set the registry type to REG_EXPAND_SZ, otherwise the type is REG_SZ

Closes #159

… set

https://learn.microsoft.com/zh-cn/windows/win32/sysinfo/registry-value-types

according to the official window documentation,
when there is a variable to be expanded such as "%name%" in the environment variable,
you need to set the registry type to REG_EXPAND_SZ, otherwise the type is REG_SZ

Closes version-fox#159
Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aooohan aooohan merged commit f2f25cc into version-fox:main Apr 1, 2024
@jan-bar jan-bar deleted the fix_win_env branch April 1, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants