Add config command #211
Merged
Add config command #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer this. |
|
It's a better implementation. I like this. |
aooohan
approved these changes
Apr 18, 2024
aooohan
reviewed
Apr 18, 2024
ahai-code
approved these changes
Apr 18, 2024
aooohan
pushed a commit
to Chance-fyi/vfox
that referenced
this pull request
Apr 18, 2024
Only string and boolean type are supported. --------- Co-authored-by: Han Li <aooohan@gmail.com>
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea from #204, this PR provides an alternative implementation.
It is implemented through reflection, so that you don't have to add a new
configsubcommand after adding a new config item.cc @cifaz