Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prefix match error #224

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix prefix match error #224

merged 2 commits into from
Apr 22, 2024

Conversation

zhylmzr
Copy link
Contributor

@zhylmzr zhylmzr commented Apr 22, 2024

PS C:\Users\zhylmzr> vfox --version
vfox version 0.4.0
PS C:\Users\zhylmzr> vfox u golang
Please select a version of golang:
  -> 1.22.2
golang@ is not installed

fix #225

Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I modified it a little bit.

@aooohan aooohan merged commit ae54645 into version-fox:main Apr 22, 2024
@Chance-fyi
Copy link
Member

The fix is not quite correct; if the following versions are available:

golang 1.22.2
golang 1.2.1

vfox use golang@1.2 will match 1.22.2.

@aooohan
Copy link
Member

aooohan commented Apr 23, 2024

The fix is not quite correct; if the following versions are available:

golang 1.22.2
golang 1.2.1

vfox use golang@1.2 will match 1.22.2.

This still needs to be optimized, so let's leave it for 0.4.2. For now, let's make sure that the previous behavior is not broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: vfox use java指令异常
3 participants