Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show available version if no version provided #236

Merged
merged 9 commits into from
Apr 26, 2024
Merged

feat: show available version if no version provided #236

merged 9 commits into from
Apr 26, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Apr 24, 2024 •
edited

close: #205

CleanShot 2024-04-24 at 14 01 27@2x

Chance-fyi
Chance-fyi reviewed Apr 24, 2024
View reviewed changes
cmd/commands/install.go Outdated Show resolved Hide resolved
Chance-fyi
Chance-fyi reviewed Apr 24, 2024
View reviewed changes
cmd/commands/install.go Outdated Show resolved Hide resolved
aooohan
aooohan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aooohan aooohan merged commit bf81bf7 into main Apr 26, 2024
3 checks passed
@aooohan aooohan deleted the feat/show-available-sdks branch April 26, 2024 01:08
@BrewTestBot BrewTestBot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chance-fyi Chance-fyi Chance-fyi left review comments

@aooohan aooohan aooohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: If no version number provided, provide a prompt to show available sdk version
3 participants
@bytemain @Chance-fyi @aooohan