Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support PreUse hook #58

Merged
merged 12 commits into from
Mar 5, 2024
Merged

feat: support PreUse hook #58

merged 12 commits into from
Mar 5, 2024

Conversation

bytemain
Copy link
Member

close: #56

aooohan
aooohan reviewed Mar 1, 2024
View reviewed changes
cmd/commands/use.go Outdated Show resolved Hide resolved
internal/plugin_test.go Show resolved Hide resolved
internal/sdk.go Outdated Show resolved Hide resolved
aooohan
aooohan reviewed Mar 1, 2024
View reviewed changes
template.lua Show resolved Hide resolved
@bytemain bytemain requested a review from aooohan March 4, 2024 03:42
@aooohan
Copy link
Member

aooohan commented Mar 4, 2024

@bytemain Hi, I’ll review this change after I solve #60 first and release 0.2.4. 👍

aooohan
aooohan reviewed Mar 5, 2024
View reviewed changes
internal/sdk.go Outdated Show resolved Hide resolved
aooohan
aooohan reviewed Mar 5, 2024
View reviewed changes
docs/plugins/create/howto.md Show resolved Hide resolved
cmd/commands/use.go Outdated Show resolved Hide resolved
@bytemain bytemain requested a review from aooohan March 5, 2024 08:17
aooohan
aooohan approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bytemain bytemain changed the title feat: support PreUse hooks feat: support PreUse hook Mar 5, 2024
@aooohan aooohan merged commit c432e3a into version-fox:main Mar 5, 2024
@aooohan
Copy link
Member

aooohan commented Mar 5, 2024

@bytemain Hi, I would like to invite you to join VersionFox as a committer. Are you interested?

@bytemain
Copy link
Member Author

bytemain commented Mar 5, 2024

Sure! And I still have some thing to do for vfox, such as:

@bytemain
Copy link
Member Author

bytemain commented Mar 5, 2024

I also want to some refactor for LuaPlugin, haha

@aooohan
Copy link
Member

aooohan commented Mar 5, 2024

Sure! And I still have some thing to do for vfox, such as:

Great! I have invited you, please check your email! 🎉

I also want to some refactor for LuaPlugin, haha

Do what you want! Let's play to our heart's content! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aooohan aooohan aooohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Use hooks for Plugins
2 participants
@bytemain @aooohan