Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't defer Record.Save #68

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

axdank
Copy link
Contributor

@axdank axdank commented Mar 2, 2024

don't defer Record.Save(), because in case the block is entered:

if !env.IsHookEnv() {
    return shell.GetProcess().Open(os.Getppid())
}

an early return is performed, and the function is not finished executing, therefore the defer is never called.

Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you are right.

@aooohan aooohan merged commit 5d254bc into version-fox:main Mar 3, 2024
@aooohan
Copy link
Member

aooohan commented Mar 3, 2024

@axdank Hi, I would like to invite you to join VersionFox as a committer. Are you interested?

@axdank
Copy link
Contributor Author

axdank commented Mar 3, 2024

Oh, yes, I would be interested in taking on the role of committer, to contribute whenever possible. Thank you for the consideration @aooohan.

@aooohan
Copy link
Member

aooohan commented Mar 4, 2024

Oh, yes, I would be interested in taking on the role of committer, to contribute whenever possible. Thank you for the consideration @aooohan.

I have invited you, please check your email. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants