Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor EnvKeys to make configuring multiple PATHs smoother #97

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

aooohan
Copy link
Member

@aooohan aooohan commented Mar 11, 2024

When the plugin configures multiple PATHs, there is no need to care about the specific OS delimiter, be it ; or :, just pass multiple PATHs and vfox will configure and de-duplicate them in order.

like this:

https://github.com/version-fox/version-fox-plugins/blob/9c8547364977506e2fdbe1b9ab83dc9b44d95c30/python/python.lua#L189-L192

When the plugin configures multiple PATHs, there is no need to care about the specific OS delimiter, be it ; or :, just pass multiple PATHs and vfox will configure and de-duplicate them in order.
@aooohan aooohan merged commit f103a47 into main Mar 11, 2024
1 check passed
@aooohan aooohan deleted the env_refactor branch March 11, 2024 08:22
ShizheChang pushed a commit to ShizheChang/vfox that referenced this pull request Mar 14, 2024
version-fox#97)

* refactor: Refactor EnvKeys to make configuring multiple PATHs smoother

When the plugin configures multiple PATHs, there is no need to care about the specific OS delimiter, be it ; or :, just pass multiple PATHs and vfox will configure and de-duplicate them in order.

* doc: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant