Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] false Bump version statement #78

Closed
Abudinka opened this issue Jul 18, 2022 · 2 comments
Closed

[BUG] false Bump version statement #78

Abudinka opened this issue Jul 18, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Abudinka
Copy link
Contributor

the commandline respond after executing versionize updates the project version upon writing the proj file thus stating something like this

Discovered 1 versionable projects
  * C:\xxx.csproj
V bumping version from 1.2.0 to 1.2.0 in projects
V updated CHANGELOG.md
V committed changes in projects and CHANGELOG.md
V tagged release as 1.2.0

i Run `git push --follow-tags origin master` to push all changes including tags

the line bumping version should say something like 1.1.4 to 1.2.0

this is probaply fixed by moveing the message in workingcopy.cs from line 150 to line 138

alternatively one could have a look why the call of Project.WriteVersion (project.cs line 58) actually alters the result of the Project.Version property

im currently making some adjustments to the software to meet my requirements and im probably opening some issue for further discussion on the issues (Spoiler: delphi and numeric versioning support)

@saintedlama
Copy link
Collaborator

Have some commits example to reproduce the issue? Thanks for filing an issue and PRs are welcome.

@saintedlama saintedlama added the bug Something isn't working label Jul 18, 2022
@Abudinka
Copy link
Contributor Author

I'am rather new to github so I properbly will make a lot of mistakes, but just to verify here is a screenshot,

as I said a fix is rather simple but does not tackle the root cause. I assume the way to go forward would be

  1. fork the project
  2. fix the bug
  3. commit it to my repo
  4. start pull request

Am I missing something

version bump commit

cabauman added a commit that referenced this issue Oct 1, 2022
* fix: moved bump statement up before csproj are altered

* test: add test to validate fix #81

Co-authored-by: Christian Günther <christian.guenther@photon-energy.de>
Co-authored-by: cabauman <cab452005@gmail.com>
@cabauman cabauman closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants