-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--pre-release does not work when using custom configuration #98
Comments
Hey @LouisRoselli, thanks for reporting. We'll look into a fix. |
insignificant commit didn't bump patch version closes #98
insignificant commit didn't bump patch version closes #98
@cabauman, I appreciate the fast turn around on this, but the issue is still not fixed. When running the following commands, I still get the same error in versionize 1.19.1: versionize --ignore-insignificant-commits --pre-release "alpha" OR versionize --pre-release "alpha" Result: Semantic versioning conflict: the next version 1.0.0-alpha.0 would be lower than the current version 1.0.0. This can be caused by using a wrong pre-release label or release as version See this sample repo as example: https://github.com/LouisRoselli/Versionize-Test ![]() |
Alright, I'll take another look. The snippet that uses |
There are no tags in the repo you shared but I assume you have a v1.0.0 tag locally on that release commit? |
@cabauman sorry about that. I pushed the tags, and yes it's v1.0.0 |
@cabauman I figured it out. A total rookie mistake on my part. It turns out I had Versionize installed globally with the --global option in "dotnet tools", and also locally by specifying it in the manifest file in the repo. The local version was on the newest, but the global installed on my machine was on an older version. Sorry for the confusion, but this is working as expected. Thank You!!!! |
Awesome! Thanks again for the bug report and the update. We didn't have a test case for that scenario, but we do now. |
The "--pre-release" option does not work correctly when using a custom configuration that has section types defined that aren't "fix" or "feat". "--pre-release" only works for "fix" and "feat". When using other custom defined types normally (NOT using --pre-release), will change the revision number...which is fine for now. Hopefully we can in the future be able to specify in the config if this is a minor or revision change for a specific type. If you have a commit mix of "fix/feat" and your custom type, it works. It just doesn't work if the custom type is the only commit. See examples below.
Project version used for all examples: "3.0.0"
Example Config for ".versionize":
Example using --pre-release (Does NOT Work):
Example not using --pre-release (WORKS):
Example using --pre-release (WORKS):
The text was updated successfully, but these errors were encountered: