Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveAttachment sets the Attachment Filename to the Full Path of the File #30

Open
randu1459 opened this issue Jul 27, 2017 · 1 comment

Comments

@randu1459
Copy link

Instead of using just the file name, the SaveAttachment method uses the entire file path. See example below:

image

I'm not sure if this is intentional or not, but I would like to add an optional argument to the method so that either the full file path (default) or just the file name is used.

This should be a simple change and I will submit a pull request shortly.

randu1459 added a commit to randu1459/VersionOne.SDK.NET.APIClient that referenced this issue Jul 27, 2017
…he Full Path of the File

Added an optional argument to the SaveAttachment method: useAbsolutePathAsFileName = true
@randu1459
Copy link
Author

This may not be an issue for any app that is using the API Client and attaching files that are located in the same directory. However, if a full path is sent passed in, it will use the full path. My PR allows for changing that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant