Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominatim location schema #122

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Nominatim location schema #122

merged 2 commits into from
Mar 6, 2021

Conversation

lenisko
Copy link
Contributor

@lenisko lenisko commented Feb 8, 2021

Need testing.

You should be able to set own location schema using nominatimSchema in config.json.

Default: {DisplayName}
Example: {Address.City}, {Address.Road} {Address.HouseNumber}

Variables to use:

PlaceId
Licence
OsmType
OsmId
Lat
Lon
PlaceRank
Category
Type
Importance
Addresstype
Name
DisplayName
Address.HouseNumber
Address.Road
Address.Neighbourhood
Address.Suburb
Address.Town
Address.City
Address.State
Address.Postcode
Address.Country
Address.CountryCode
Boundingbox

@versx
Copy link
Owner

versx commented Feb 8, 2021

Looks good, maybe add support for Gmaps too if it's not too much? 😄

@lenisko
Copy link
Contributor Author

lenisko commented Feb 8, 2021

@versx sure 👍

@unseenmagik
Copy link

Hay Len.
I have pulled and tested this PR today.
After changing the nominatimSchema too:
"nominatimSchema": "{Address.HouseNumber},{Address.Road} ,{Address.City},{Address.Postcode}",
I can confirm that the full long address is still sent.

@lenisko
Copy link
Contributor Author

lenisko commented Feb 24, 2021

@unseenmagik Hey!

By default address schema is untouched.
Make sure you have recompiled WhMgr and executed it with correct config.json.

If you are using google as reverse geocoding API it won't work. I couldn't find good way to add support for Google and sadly I'm too busy to brainstorm over it.

@unseenmagik
Copy link

@unseenmagik Hey!

By default address schema is untouched.
Make sure you have recompiled WhMgr and executed it with correct config.json.

If you are using google as reverse geocoding API it won't work. I couldn't find good way to add support for Google and sadly I'm too busy to brainstorm over it.

@lenisko Thanks.
I have compiled / built the PR, updated the config.json and I still don’t see the shortened address.
I am using my own Nominatim server also

@lenisko
Copy link
Contributor Author

lenisko commented Feb 25, 2021

@unseenmagik Steps I took to check:

  • pulled master
  • merged this PR to master
  • dotnet build in main repo directory
  • set "nominatimSchema": "{Address.City}, {Address.Road} {Address.HouseNumber}" inside repo/bin/config.json
  • dotnet WhMgr.dll in repo/bin directory

It's working.

@versx
Copy link
Owner

versx commented Feb 25, 2021

@unseenmagik Hey!
By default address schema is untouched.
Make sure you have recompiled WhMgr and executed it with correct config.json.
If you are using google as reverse geocoding API it won't work. I couldn't find good way to add support for Google and sadly I'm too busy to brainstorm over it.

@lenisko Thanks.
I have compiled / built the PR, updated the config.json and I still don’t see the shortened address.
I am using my own Nominatim server also

Maybe you didn't build after merging PR to master possibly?

@versx versx merged commit 16f8232 into versx:master Mar 6, 2021
@lenisko lenisko deleted the nominatim_schema branch March 6, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants