Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Alarm PVP Filters Simplification #288

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

versx
Copy link
Owner

@versx versx commented Jun 23, 2022

Changes channel alarm Pokemon PvP filters to accept an object with one filter for the specified league instead of a list.

Current implementation:

    ...
    "pvp": {
        // Add or remove any PVP league filtering keys
        // depending on the interested ranks
        // Little league rank filtering
        "little": [{
            // Minimum rank of #1 for PVP rank stats
            "min_rank": 1,
            // Maximum rank of #5 for PVP rank stats
            "max_rank": 5,
            // Minimum CP value of 400 for PVP rank stats
            "min_cp": 400,
            // Maximum CP value of 500 for PVP rank stats
            "max_cp": 500,
            // Minimum PVP product stat
            "min_percent": 90,
            // Maximum PVP product stat
            "max_percent": 100,
            // Gender filtering requirement (*, m, or f)
            "gender": "*"
        }],
        // Great league rank filtering
        "great": [{
            "min_rank": 1,
            "max_rank": 5,
            "min_cp": 1400,
            "max_cp": 1500,
            "gender": "m"
        }],
        // Ultra league rank filtering
        "ultra": [{
            "min_rank": 1,
            "max_rank": 25,
            "min_cp": 2400,
            "max_cp": 2500,
            "gender": "f"
        },{
            "min_rank": 1,
            "max_rank": 5,
            "min_cp": 2300,
            "max_cp": 2400
        }]
    },
    ...

New implementation:

    ...
    "pvp": {
        // Add or remove any PVP league filtering keys
        // depending on the interested ranks
        // Little league rank filtering
        "little": {
            // Minimum rank of #1 for PVP rank stats
            "min_rank": 1,
            // Maximum rank of #5 for PVP rank stats
            "max_rank": 5,
            // Minimum CP value of 400 for PVP rank stats
            "min_cp": 400,
            // Maximum CP value of 500 for PVP rank stats
            "max_cp": 500,
            // Minimum PVP product stat
            "min_percent": 90,
            // Maximum PVP product stat
            "max_percent": 100,
            // Gender filtering requirement (*, m, or f)
            "gender": "*"
        },
        // Great league rank filtering
        "great": {
            "min_rank": 1,
            "max_rank": 5,
            "min_cp": 1400,
            "max_cp": 1500,
            "gender": "m"
        },
        // Ultra league rank filtering
        "ultra": {
            "min_rank": 1,
            "max_rank": 25,
            "min_cp": 2400,
            "max_cp": 2500,
            "gender": "f"
        }
    },
    ...

@versx versx added the enhancement New feature or request label Jun 23, 2022
@versx versx merged commit 6e5cfef into v5-rewrite Jun 24, 2022
@versx versx deleted the v5-rewrite_pvp_filter_update branch June 25, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant